Merged
Conversation
Alexis-Jacob
force-pushed
the
dev-app_id_should_be_optional
branch
from
0fb3736 to
95ddadc
Compare
maingoh
reviewed
Oct 1, 2019
Alexis-Jacob
force-pushed
the
dev-app_id_should_be_optional
branch
2 times, most recently
from
1b21230 to
7becd4a
Compare
maingoh
reviewed
Oct 2, 2019
Contributor
maingoh
left a comment
maingoh
left a comment
There was a problem hiding this comment.
Can you remove this line
and update the README.md (maybe explain app_id is now optional and api_key must be provided with named parameter)
maingoh
approved these changes
Oct 2, 2019
Alexis-Jacob
force-pushed
the
dev-app_id_should_be_optional
branch
from
29a0cf6 to
b5734b1
Compare
| raise DeepomaticException("Please specify 'app_id' and 'api_key' either by passing those values to the client" | ||
| " or by defining the DEEPOMATIC_APP_ID and DEEPOMATIC_API_KEY environment variables.") | ||
| if api_key is None: | ||
| raise DeepomaticException("Please specify 'api_key' either by passing those values to the client" |
| " or by defining the DEEPOMATIC_APP_ID and DEEPOMATIC_API_KEY environment variables.") | ||
| if api_key is None: | ||
| raise DeepomaticException("Please specify 'api_key' either by passing those values to the client" | ||
| " or by defining the DEEPOMATIC_API_KEY environment variables.") |
Contributor
There was a problem hiding this comment.
s/variables/variable/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #64